Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue when deploy fails when images specified as file paths … #272

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

Fixing issue when deploy fails when images specified as file path in skill.json

The issue happens on first deploy when we dont have endpoint urls.

Reported in #251

Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some cross dependency between two controller, might need to decouple that later

@RonWang RonWang merged commit b8341f8 into develop Aug 4, 2020
@RonWang RonWang deleted the fix-icon-deploy branch August 4, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants