Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry #278

Merged
merged 1 commit into from
Aug 26, 2020
Merged

feat: add telemetry #278

merged 1 commit into from
Aug 26, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

Adding telemetry

Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

OPT OUT and disable telemetry by setting the 'share_usage' key to 'false'
in '~/.ask/cli_config'.
Learn more: https://developer.amazon.com/docs/alexa/smapi/ask-cli-telemetry.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have this link ready?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont.

Copy link
Contributor

@RonWang RonWang Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we have to make sure this link and the feat go public together, could you talk to the docs team?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a ticket. not sure how long will it take.

test/functional/run-test.js Show resolved Hide resolved
test/integration/run-test.js Show resolved Hide resolved
test/unit/run-test.js Show resolved Hide resolved
@RonWang RonWang merged commit 54f972b into develop Aug 26, 2020
@RonWang RonWang deleted the telemetry branch August 26, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants