Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing restriction for replay file to have .json extension #354

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

Addressing #347 and doing additional clean up

  1. minor formatting change for some options descriptions
  2. removing restriction for replay file to have .json extension
  3. removed code to read/ write yml replay file, since it was not possible due to our validations.

test non exisiting file

ask dialog -r not-existing
[Error]: Failed to parse file: not-existing.
File not-existing not exists.

test non json file

ask dialog -r out
[Error]: Failed to parse file: out.
out: Unexpected string in JSON at position 166

test good file

ask dialog -r out

========================================================== Welcome to ASK Dialog ==========================================================
========================================= Replaying a multi turn conversation with Alexa from out =========================================
======================================== Alexa will then evaluate your input and give a response! =========================================

User  > open node crazy test
Alexa > Welcome, you can say Hello or Help. Which would you like to try?
User  > hello
Alexa > Hello World!
User  > .quit

================================================================ Goodbye! =================================================================

@kakhaUrigashvili kakhaUrigashvili linked an issue Dec 3, 2020 that may be closed by this pull request
@kakhaUrigashvili kakhaUrigashvili changed the title Dialog minor cleanup fix: removing restriction for replay file to have .json extension Dec 3, 2020
Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RonWang RonWang merged commit 09f6270 into develop Dec 8, 2020
@RonWang RonWang deleted the dialog-minor-cleanup branch December 8, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ask dialog --reply nosuchfile has unclear message
2 participants