fix: move the temp zip file to .ask to integ with extension #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There's a new extension feature skill-package validator, which is a fileSystemWatcher on skilPackage folder. If the watcher catch any unexecpeted files, it will throw warn in the extension.
Recently there's customer tried to use the cli to deploy skill with the extension opened. Since the cli will generate the temp zip under skillPackage, it will trigger the extension alert.
Description of changes:
Instead of generating the zip file under skillPackage folder, rightnow will move the temp zip to .ask folder.
Changed the zipUtil.createTempZip function to take in a new param which will specify the output dir. And in the skillDeployController, add logic to get the .ask folder path and pass it into the createTempZip.
Fixed all the unit tests. And tested this feature with a skill at my local, the temp zip file will now generated inside .ask folder.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.