fix: do not set DEFAULT to simulation.type when making simulate-skill request #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
approved these changes
Aug 3, 2021
| @@ -125,7 +125,7 @@ class DialogCommand extends AbstractCommand { | |||
| Messenger.getInstance().info(`Defaulting locale to the first value from the skill manifest: ${firstLocaleFromManifest}`); | |||
| } | |||
| locale = locale || process.env.ASK_DEFAULT_DEVICE_LOCALE || firstLocaleFromManifest; | |||
| const simulationType = !stringUtils.isNonBlankString(cmd.simulationType) ? 'DEFAULT' : cmd.simulationType; | |||
| const simulationType = stringUtils.isNonBlankString(cmd.simulationType) ? cmd.simulationType : undefined; | |||
There was a problem hiding this comment.
Why is DEFAULT no longer the default value?
There was a problem hiding this comment.
The simulation.type in simulate-skill request should only be set when it's to simulate a NFI enabled skill. We should not set this field at all rather then letting developers set this field explicitly.
The meaning of the DEFAULT here is ambiguous, which we have requested the service side to correct it. We should set it as undefined if user doesn't set it explicitly in the --simulation-type option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue #405
Before
AFter the fix:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.