-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skill events property to ask-resources.json #410
Conversation
@Shreyas-vgr any chance for this and my other PRs to be reviewed? Some of them have been submitted a while back. I am forced to maintain a forked ask-cli version for my team. It would nice if we could revert back to using the official version. |
@Shreyas-vgr sorry for asking again. Any chance this and my other PRs get reviewed? Some of them have been submitted a year ago. It would be nice to know if there is any interest for any of these PRs to get merged at some point. Thanks. |
Hi @jsetton, thanks for the PR and apologies for it not being reviewed earlier. |
@Shreyas-vgr @CamdenFoucht Sorry to ask again but any idea on when this and the other PRs will get reviewed? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll get this out when we release next CLI version Monday :)
Sorry for the awfully long time to get this in, thank you so much for the contribution!
Hey @jsetton just wanted to let you know we released 2.28.0 which included your pull-requests. Thank you so much for the contributions and apologies for the long delay on getting them in! |
Issue #, if available:
Fixes: #47
Description of changes:
This change adds the ability to customize the events property of the skill manifest when the deployed Lambda function can handle these events.
The original support for "events" via the
targetEndpoint
property was replaced by the newskillEvents
property since the previous implementation to add skill events support wasn't useable out of the box.The documentation was updated and includes some minor cleanup.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.