Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skill events property to ask-resources.json #410

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Sep 4, 2021

Issue #, if available:

Fixes: #47

Description of changes:

This change adds the ability to customize the events property of the skill manifest when the deployed Lambda function can handle these events.

The original support for "events" via the targetEndpoint property was replaced by the new skillEvents property since the previous implementation to add skill events support wasn't useable out of the box.

The documentation was updated and includes some minor cleanup.

{
  "askcliResourcesVersion": "2020-03-31",
  "profiles": {
    "default": {
      "skillMetadata": {
        "src": "./skill-package"
      },
      "code": {
        "default": {
          "src": "./lambda"
        }
      },
      "skillInfrastructure": {
        "type": "@ask-cli/lambda-deployer",
        "userConfig": {
          "runtime": "nodejs12.x",
          "handler": "index.handler",
          "skillEvents": {
            "publications": ["AMAZON.MessageAlert.Activated"],
            "subscriptions": ["SKILL_PROACTIVE_SUBSCRIPTION_CHANGED"]
          }
        }
      }
    }
  }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jsetton
Copy link
Contributor Author

jsetton commented Jan 11, 2022

@Shreyas-vgr any chance for this and my other PRs to be reviewed? Some of them have been submitted a while back. I am forced to maintain a forked ask-cli version for my team. It would nice if we could revert back to using the official version.

@jsetton
Copy link
Contributor Author

jsetton commented Apr 19, 2022

@Shreyas-vgr sorry for asking again. Any chance this and my other PRs get reviewed? Some of them have been submitted a year ago. It would be nice to know if there is any interest for any of these PRs to get merged at some point. Thanks.

@Shreyas-vgr
Copy link
Contributor

Hi @jsetton, thanks for the PR and apologies for it not being reviewed earlier.
We will go through the PRs soon and merge it to mainline once ready.

@jsetton
Copy link
Contributor Author

jsetton commented Aug 1, 2022

@Shreyas-vgr @CamdenFoucht Sorry to ask again but any idea on when this and the other PRs will get reviewed? Thanks.

Copy link
Contributor

@CamdenFoucht CamdenFoucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get this out when we release next CLI version Monday :)

Sorry for the awfully long time to get this in, thank you so much for the contribution!

@CamdenFoucht CamdenFoucht removed the request for review from Shreyas-vgr August 4, 2022 16:28
@CamdenFoucht CamdenFoucht merged commit ccf7972 into alexa:develop Aug 4, 2022
@jsetton jsetton deleted the skill-events branch August 4, 2022 16:32
@jsetton jsetton restored the skill-events branch August 4, 2022 18:57
@jsetton jsetton deleted the skill-events branch August 4, 2022 19:00
@CamdenFoucht
Copy link
Contributor

Hey @jsetton just wanted to let you know we released 2.28.0 which included your pull-requests. Thank you so much for the contributions and apologies for the long delay on getting them in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Skill Events Endpoint Automated Deployment Support
4 participants