Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi v17 Support #4

Closed
3 tasks
timcosta opened this issue Oct 24, 2017 · 5 comments
Closed
3 tasks

Hapi v17 Support #4

timcosta opened this issue Oct 24, 2017 · 5 comments
Assignees

Comments

@timcosta
Copy link

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

  • Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
  • Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

    Possible dev flow for updating

    • Clone Hapi
    • npm link within the Hapi repo
    • npm link hapi within your plugin repo
    • Your plugin will now be using v17 of Hapi branch for tests
  • Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

  • Support is being dropped for all versions of Node <8.0.0.
  • Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
  • Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.
@alexandrebodin alexandrebodin self-assigned this Oct 24, 2017
@alexandrebodin
Copy link
Owner

Cannot update without updating good and oppsy.

@BorntraegerMarc
Copy link

@alexandrebodin can we expect an update?

@alexandrebodin
Copy link
Owner

@BorntraegerMarc To be honest there is no update on my part. I need to wait for good to be updated.
I'm waiting for hapijs/good#568 to be resolved first :)

@a632079
Copy link

a632079 commented Jan 27, 2018

Need Support for Hapi v17. Thanks!

@alexandrebodin
Copy link
Owner

alexandrebodin commented Jan 28, 2018

@a632079

Just need to update the dependencies now that good is updated

You will need to use good 8.0.0-rc1 for now but this will work with hapi-good-winston 2.0.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants