Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "internal" consistency for individual params of a group #16

Open
alexcasalboni opened this issue Feb 28, 2018 · 0 comments
Open

Improve "internal" consistency for individual params of a group #16

alexcasalboni opened this issue Feb 28, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@alexcasalboni
Copy link
Owner

_max_age and _last_refresh_time are not currently "shared" between a SSMParameterGroup and its SSMParameter objects.

While #14 has fixed the refreshing bug due to this inconsistency, we could somehow keep the internal Refreshable fields in sync between a group and its parameters to avoid more problems in the future. The current solution always delegates _should_refresh to the group.
@alexcasalboni alexcasalboni added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcasalboni