Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: unsupported output in build script of curl-sys v0.4.76+curl-8.10.1: cargo::rustc-check-cfg=cfg(libcurl_vendored,link_libnghttp2,link_libz,link_openssl,) #576

Closed
glandium opened this issue Sep 20, 2024 · 5 comments · Fixed by #581 · May be fixed by #577

Comments

@glandium
Copy link
Contributor

glandium commented Sep 20, 2024

#575 accidentally increased the (undocumented) MSRV to 1.80, and older rust versions fail to compile.

@iamalwaysuncomfortable
Copy link

I'm Also experiencing this issue

@nabijaczleweli
Copy link
Contributor

Just got this report downstream: nabijaczleweli/cargo-update#277

This user is on the current Ubuntu LTS, which ships 1.75.
Naturally, I would like to avoid fielding more reports like this.

There's no reason to not spell this as cargo:rustc-check-cfg (just as there was no reason to devise the cargo:: syntax in the first place, especially without a failover period).

@alexcrichton
Copy link
Owner

Naturally, I would like to avoid fielding more reports like this.

Personally I find this tone abrasive and unnecessarily conflict-oriented. No one's trying to foist work onto you and force you to deal with things. Bugs like this happen, and it's a part of how OSS works. I'd encourage you to pause before making comments like this since it ends up not really helping anyone for you to vent frustration to strangers on the internet.

@nabijaczleweli
Copy link
Contributor

nabijaczleweli commented Sep 30, 2024

Sorry, that's not what I meant by this. This was an ill-thought short-hand for "I expect to see more of these [from Ubuntu LTS users], so I hope to fix this myself in short order, and would like to hope for this to be releasable on its own [such that I can avoid fielding more reports like this].". my b if that read too short. happens, of course, and I'm happy to chase this up the dependency tree

@alexcrichton
Copy link
Owner

alexcrichton commented Sep 30, 2024

Thanks for clarifying! Also a good reminder for me to assume good faith on everyone's behalf. This is a case of only-text communication not being easy, and I know I mess it up all the time as well. Regardless thanks for helping to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants