Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tied to specific platform toolset on windows #6

Closed
Diggsey opened this issue May 20, 2017 · 3 comments
Closed

Build tied to specific platform toolset on windows #6

Diggsey opened this issue May 20, 2017 · 3 comments

Comments

@Diggsey
Copy link
Contributor

Diggsey commented May 20, 2017

When building for -msvc with the VC++ 2015 build tools, the build fails:

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools. Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\Users\diggs\Projects\rustup-rs\target\debug\build\lzma-sys-8de572d4e0ca373d\out\build\windows\liblzma.vcxproj]

The project should probably not be tied to a specific platform toolset version.

@alexcrichton
Copy link
Owner

Unfortunately I don't really know anything about vcxproj files and whatnot, is there a way to fix this?

@Diggsey
Copy link
Contributor Author

Diggsey commented May 20, 2017

Yep, you just need to pass /p:PlatformToolset=v140/v120/v110/v100/v90 to the msbuild invocation, depending on the version of the VC++ build tools / visual studio.

@alexcrichton
Copy link
Owner

Ah ok, PRs to do this are of course always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants