Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrowContainer: docs incorrect for targetRect/childRect; arrowSize seems required #96

Open
colepeters opened this issue Dec 14, 2020 · 0 comments

Comments

@colepeters
Copy link

I've found a couple issues using the ArrowContainer on the latest release (6.0.2):

  • It looks like the prop that used to be targetRect has been renamed to childRect, but the docs still use targetRect in the API table, and both targetRect and childRect in the examples
  • When I don't specify an arrowSize on the ArrowContainer, an arrow is not rendered; it only renders once I provide a size. Was the default perhaps removed?

I would've submitted a PR for the docs change, but since I'm not sure if they also need to change based on the arrowSize, I'll leave it for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant