Error objects cannot be expanded + Fix for #20

[skleeschulte]

Error objects in the state tree cannot be expanded. Thats because iterating with for...in and hasOwnProperty doesn't work here. However this should easily be fixed by adding this before line 30 in JSONObjectNode.js:

if (data instanceof Error) {
    data = Object.getOwnPropertyNames(data).reduce(function (errorObj, prop) {
        errorObj[prop] = data[prop];
        return errorObj;
    }, {});
}

In addition, to solve Objects without prototype chain are broken #20 , line 32 in JSONObjectNode.js could be changed to:

if (Object.getPrototypeOf(data) === null || data.hasOwnProperty(key)) {

(IMHO thats better than PR Fixes #20, expanding of objects without prototype #21.)

I would create a pull request, but I cannot test this, because I cannot build the package. (I cloned it from github, but get lot's of errors on npm install, npm build and npm run lint. Even after fixing npm install and npm build (by removing all the carets from the dependency versions in package.json and installing [email protected]), with npm build the output in lib looks different from what I get from npm install react-json-tree.)

But I'm sure someone can do it. :)

[chibicode]

Thanks! Closed by #23

[skleeschulte]

PR #23 only fixes issue #20 by adding if (Object.getPrototypeOf(data) === null || data.hasOwnProperty(key)) {. The main thing this issue is about is that errors cannot be extended, which is because the for...in loop doesn't iterate over Error instance properties.

[chibicode]

@skleeschulte sorry I read it wrong, reopened this issue

[alexkuz]

Should be fixed by dadf3d3

[dorian-marchal]

Looks like the issue is still there (in redux-devtools, at least, which uses v0.11).