Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds equidimensional decomposition and module order option to Sig GB's #85

Merged
merged 251 commits into from
Oct 10, 2024
Merged

Adds equidimensional decomposition and module order option to Sig GB's #85

merged 251 commits into from
Oct 10, 2024

Conversation

RafaelDavidMohr
Copy link

This would add equidimensional decomposition as in https://arxiv.org/abs/2409.17785 to AlgebraicSolving.jl, plus it would add position-over-term to sig_groebner_basis.

I have to add some tests and then this is good to go.

@RafaelDavidMohr
trace also diagonal coeffs
9b8dda9
@RafaelDavidMohr
also trace signatures
4a818ca
@RafaelDavidMohr
function for adding polynomials
9217100
@RafaelDavidMohr
move to module file
3033a8c
@RafaelDavidMohr
further work on computing module rep
02f1b11
@RafaelDavidMohr
first version for computing module rep
85b794d
@RafaelDavidMohr
fixes some module construction bugs
4de1d03
@RafaelDavidMohr
adds cache for module computations
a005711
@RafaelDavidMohr
adds option to just trace one index in module
b931f64
@RafaelDavidMohr
rough sketch for saturating
c179173
@RafaelDavidMohr
scratch sigsat
0f52b5f
@RafaelDavidMohr
add index ordering
e2d0a75
@RafaelDavidMohr
splits out add_basis_elem
34c42b2
@RafaelDavidMohr
adds some preparatory code for colon ideal computations
86feefc
@RafaelDavidMohr
removes commented out code
5dbd4cd
@RafaelDavidMohr
splits out syzygy processing func
d985e58
@RafaelDavidMohr
further prep work
8a9b6b4
@RafaelDavidMohr
change index order type
962c913
@RafaelDavidMohr
addds code for inserting zero divisor
dbbeba6
@RafaelDavidMohr
fix bug in zero div insertion
02889fd
@RafaelDavidMohr
adds code for multiple col rhs's
f637eb7
@RafaelDavidMohr
adjusts tracer data structure (untested)
4dc4ffa
@RafaelDavidMohr
adjusts for variable input size
c666455
@RafaelDavidMohr
adds function for making room for inp el
cfe8d0b
@RafaelDavidMohr
splits out func for adding input el
6bf8c2e
@RafaelDavidMohr
fix some rewrite tree bugs
569162b
@RafaelDavidMohr
fix an index order bug
d754e10
@RafaelDavidMohr
fix a pair selection bug
41d6c40
@RafaelDavidMohr
remove some testing code
d1155a3
@RafaelDavidMohr
split out rewriting into own file
968c2f5
@ederc
Copy link
Collaborator

ederc commented Oct 4, 2024

Please also add documentation for new functionality.

@RafaelDavidMohr
Copy link
Author

Please also add documentation for new functionality.

I put the new equidimensional_decomposition function in a seperate file (in case we want to add other decomposition algorithms) and added documentation.

@RafaelDavidMohr RafaelDavidMohr marked this pull request as ready for review October 4, 2024 12:15
@RafaelDavidMohr
Copy link
Author

Doc file is also added.

@ederc ederc merged commit aa10b0c into algebraic-solving:main Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafaelDavidMohr @ederc