-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to autocomplete.js v1 [BREAKING CHANGES] #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising!
Main issue is that the results are not closed when we click away and stay open forever.
@sbellone That's because the We talk about this in the "Debugging" section of our docs. |
Co-authored-by: Sylvain Bellone <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I've just found out that it doesn't work correctly if the index has no |
All Netlify indices are pre configured with |
Automatically? That's not what I have observed. They currently have What's the problem of sending them at runtime just in case since we rely on them for the display? |
ah, we should just change our default index settings then. |
Ok but we can also have the UI fallback to the actual fields if no snippetting available, to not have the UI broken because of index settings |
Did the change but index settings are very tied to the UI, they change it they assume it imo. |
True, so a fallback on raw fields if no snippets available permits to let user controlling the length of the snippets actually. As you prefer! |
Closes #76
Changes
algoliasearchNetlify()
will throw if missing mandatory option400px
widthHow to migrate
solution: remove your input, create an empty node, e.g:
<div id="#search"></div>
and useselector: "#search"
color
property has been removed in favor oftheme
for improved theming ability.silenceWarnings
has been removedautocomplete
property has been removed in favor ofselector
andhitsPerPage
at the top levelpanelPlacement: 'input-wrapper-width'
, to improve this behavior you can adapt the CSS on your own with media queries.