fix(clear): Avoid error when clear is called after destroy (#287)

* dataset-clear-npe-fix * rename test for clarity
algolia · Aug 28, 2019 · 244425d · 244425d
1 parent 93c21b7
commit 244425d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/autocomplete/dataset.js b/src/autocomplete/dataset.js
@@ -256,9 +256,11 @@ _.mixin(Dataset.prototype, EventEmitter, {
   },
 
   clear: function clear() {
-    this.cancel();
-    this.$el.empty();
-    this.trigger('rendered', '');
+    if (this.$el) {
+      this.cancel();
+      this.$el.empty();
+      this.trigger('rendered', '');
+    }
   },
 
   isEmpty: function isEmpty() {

diff --git a/test/unit/dataset_spec.js b/test/unit/dataset_spec.js
@@ -462,6 +462,14 @@ describe('Dataset', function() {
       this.dataset.clear();
       expect(spy).toHaveBeenCalled();
     });
+
+    it('should not throw if called right after destroy()', function() {
+      this.source.and.callFake(fakeGetWithSyncResults);
+      this.dataset.update('woah');
+      this.dataset.destroy();
+      this.dataset.clear();
+      expect(this.dataset.getRoot()).toBeNull();
+    });
   });
 
   describe('#isEmpty', function() {