Add cache disabling for datasets #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one definitely sounds like the more reasonable of both PRs, @samouss, what do you think? |
samouss
requested changes
Oct 8, 2018
src/autocomplete/dataset.js
Outdated
| @@ -37,6 +37,8 @@ function Dataset(o) { | |||
|
|
|||
| this.debounce = o.debounce; | |||
|
|
|||
| this.disableCache = !!o.disableCache; | |||
There was a problem hiding this comment.
I would go for enableCache (or something similar) with a default value to true rather than disableCache. Positive condition are a bit easier to reason about.
src/autocomplete/dataset.js
Outdated
| @@ -235,6 +237,10 @@ _.mixin(Dataset.prototype, EventEmitter, { | |||
| }, | |||
|
|
|||
| shouldFetchFromCache: function shouldFetchFromCache(query) { | |||
| if (this.disableCache) { | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
Once we have inverted the condition we can inline the condition.
|
@Haroenv The tests are failing because of the Netlify ENV variable not available on contributors PR. |
|
Agreed with @samouss, |
added 2 commits
October 12, 2018 09:25
…ete.js into dataset-disable-cache
samouss
approved these changes
Oct 12, 2018
Haroenv
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to disable cache retrieval of subsequent identical queries via a boolean flag in dataset config called
disableCache.Use case:
Related issues:
Additional notes: