fix(getSuggestions): allow nested arrays to be returned #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d5fb35:
|
francoischalifour
requested changes
Oct 10, 2020
packages/autocomplete-core/src/__tests__/getAutocompleteSetters.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/__tests__/getAutocompleteSetters.test.ts
Outdated
Show resolved
Hide resolved
Haroenv
commented
Oct 12, 2020
Haroenv
commented
Oct 12, 2020
packages/autocomplete-core/src/__tests__/getAutocompleteSetters.test.ts
Outdated
Show resolved
Hide resolved
Haroenv
force-pushed
the
fix/get-suggestions-nested
branch
from
f7c92af
to
8e4b48f
Compare
this is useful, since it allows getAlgoliaHits to be used top-level, but also within a single source, without having to take the first element of the array manually
Co-authored-by: François Chalifour <[email protected]>
Haroenv
force-pushed
the
fix/get-suggestions-nested
branch
from
13e6dc3
to
dc4ef68
Compare
packages/autocomplete-core/src/__tests__/getAutocompleteSetters.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/__tests__/getAutocompleteSetters.test.ts
Outdated
Show resolved
Hide resolved
francoischalifour
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It flattens the result of getSuggestions. this is useful, since it allows getAlgoliaHits to be used top-level, but also within a single source, without having to take the first element of the array manually
Result
you can use getAlgoliaHits top-level in getSources, but also in getSuggestions (like in the docs: https://algolia-autocomplete.netlify.app/docs/autocomplete-js)