Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): prepare Autocomplete Classic Theme #361

Merged
merged 19 commits into from
Dec 2, 2020

Conversation

francoischalifour
Copy link
Member

This prepares the package and tooling (build, lint, CI) for the upcoming Autocomplete Classic Theme.

There's no need to review the CSS files (except the conventions used) because we'll swap this WIP CSS rules with the official theme next week.

postcss.config.mjs Outdated Show resolved Hide resolved
@eunjae-lee
Copy link
Contributor

codesandbox ci is failing here

@francoischalifour
Copy link
Member Author

@eunjae-lee The CodeSandbox CI builds fails because I can't find a way to tell their CI to use the Node version from .nvmrc (Node 14) to use imports with MJS files. We got in touch with them on Twitter.

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if codesandbox is fixed now / later, good for me; otherwise maybe revert to .js and commonjs?

ship.config.js Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 825675e:

Sandbox Source
@algolia/js-example Configuration
@algolia/react-renderer-example Configuration

@francoischalifour francoischalifour merged commit 8638a98 into next Dec 2, 2020
@francoischalifour francoischalifour deleted the feat/autocomplete-theme-classic branch December 2, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants