Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): sync detached mode open state #556

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

francoischalifour
Copy link
Member

Description

This synchronizes the internal open state with the detached overlay open state.

It was a missing behavior that caused some trouble to users, unable to trigger an action (other than a link) after a selection on detached mode.

Changes

We're now syncing the detached open state with the internal isOpen state. This means that shouldPanelOpen always return true on detached mode now. Otherwise, the detached overlay wouldn't be able to stay open under user conditions.

Related

This synchronizes the internal open state with the detached overlay open state.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 30, 2021

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! in the linked sandbox with this PR it seems like the modal also successfully closes when you want it to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close detached modal after navigation
3 participants