Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): render noResults template when openOnFocus is true #573

Merged
merged 2 commits into from
May 6, 2021

Conversation

shortcuts
Copy link
Member

Summary
On an empty query, nothing is rendered when openOnFocus is true and a noResults template is provided.

live reproduction:

  • Focus input: nothing is rendered.
  • Type something: noResults template is rendered.

Result
The noResults template is rendered on an empty query with openOnFocus: true

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

Copy link
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

packages/autocomplete-js/src/render.tsx Outdated Show resolved Hide resolved
packages/autocomplete-js/src/render.tsx Outdated Show resolved Hide resolved
@shortcuts shortcuts merged commit f2154c8 into next May 6, 2021
@shortcuts shortcuts deleted the fix/openOnFocus-noResults branch May 6, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants