fix(js): provide fallback method for addEventListener on media queries
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 369e91a:
|
packages/autocomplete-js/src/__tests__/detachedMediaQuery.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-js/src/__tests__/detachedMediaQuery.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-js/src/__tests__/detachedMediaQuery.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: François Chalifour <[email protected]>
Co-authored-by: François Chalifour <[email protected]>
shortcuts
force-pushed
the
fix/mediaQuery-eventListener
branch
from
ac0e92c
to
369e91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
addEventListeneron media queries isn't supported for iOS <= 13.6, which causes Autocomplete to crash the application. We now provide a fallback solution to the deprecated methodaddListener.Result
Autocomplete no longer crashes on iOS <= 13.6
Video
Following the steps of #597, the device is an iPhone 11 running on iOS 13.6.
app.tsx(from the one above) copy pasted. sandboxScreen.Recording.2021-06-09.at.17.41.23.mov
Closes #597