Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish examples to npm #31

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Don't publish examples to npm #31

merged 2 commits into from
Jul 3, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

As of [email protected] (gatsbyjs/gatsby#15284), we now parse GraphQL queries in dependencies to enable packages to ship queries!

The examples in this repo however interfere with this and cause this package to break (details in gatsbyjs/gatsby#15344)

We highly recommend not shipping examples to npm and this PR fixes this by adding it to .npmignore

Cheers from the gatsby team!

@Haroenv
Copy link
Contributor

Haroenv commented Jul 3, 2019

Thanks @sidharthachatterjee! We usually use files in package.json though. Can you change it to include just gatsby-node.js there? If it's too much work I can also do it myself

@sidharthachatterjee
Copy link
Contributor Author

Thank you for the quick response, @Haroenv! I've removed .npmignore and added files instead 🙌

@sidharthachatterjee sidharthachatterjee changed the title Add example to .npmignore Don't publish examples to npm Jul 3, 2019
@Haroenv Haroenv merged commit b042481 into algolia:master Jul 3, 2019
@Haroenv
Copy link
Contributor

Haroenv commented Jul 3, 2019

published 0.3.1 with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants