Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incentives: Add fields in block header for proposer and fees collected. #617

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Incentives: Add fields in block header for proposer and fees collected. #617

merged 5 commits into from
Apr 24, 2024

Conversation

jannotti
Copy link
Contributor

These are needed for algorand/go-algorand#5740 and should not be merged until that work is finalized.

@jannotti jannotti changed the title Add fields in block header for proposer and fees collected. Incentives: Add fields in block header for proposer and fees collected. Sep 18, 2023
@jannotti jannotti self-assigned this Sep 18, 2023
cce added a commit to algorand/indexer that referenced this pull request Mar 21, 2024
@cce
update for algorand/go-algorand#5757 and algorand/go-algorand-sdk#617
4e90200
@jannotti
Add fields in block header for proposer and fees collected.
5ce1569 
These are needed for algorand/go-algorand#5740
and should not be merged until that work is finalized.
@jannotti jannotti marked this pull request as ready for review April 23, 2024 17:44
@jasonpaulos
Copy link
Contributor

I'd expect this to also update protocol/config/consensus.go

@jannotti
Copy link
Contributor Author

I'd expect this to also update protocol/config/consensus.go

Do we just keep them in perfect sync? Is the intent just to make everything available to callers? I can't think of any external functionality that would need access to the params, but I can see why we might have such an exposure policy. (We surely don't have it for any other sdk though)

@jasonpaulos
Copy link
Contributor

We only have it in this SDK for indexer & conduit to consume. There are a few consensus params that they check, such as whether rewards (the old style) are enabled, which influence their behavior/how they report certain things.

The cross repo type check in algod also verifies that the consensus params are in sync.

@cce cce mentioned this pull request Apr 24, 2024
Closed
@jannotti
Copy link
Contributor Author

I think that's done - it's entirely manual, huh? There was more stuff in consensus.go in go-algorand, plus imports change for the sdk, so I just made the same changes by hand. I guess it would be nice to script it using some mark comments in the source file.

@cce
Copy link

cce commented Apr 24, 2024

the block header is missing AbsentParticipationAccounts

@jasonpaulos
Copy link
Contributor

I think that's done - it's entirely manual, huh?

I thought it was a straight up copy-paste, but now I see the functions LoadConfigurableConsensusProtocols, SetConfigurableConsensusProtocols, and PreloadConfigurableConsensusProtocols from go-algorand are omitted. Perhaps we should move those to their own file so that it really is as simple as copy-paste (except for the "relative" import statement)

@jannotti
Copy link
Contributor Author

It was unclear to me how that model is used, but I figured I should copy the way expired accounts was done.

a12e954

@jannotti jannotti merged commit 7914b59 into algorand:develop Apr 24, 2024
5 checks passed
onetechnical pushed a commit to onetechnical/indexer that referenced this pull request Apr 25, 2024
@cce @onetechnical
update for algorand/go-algorand#5757 and algorand/go-algorand-sdk#617
8d27709
@github-actions github-actions bot mentioned this pull request May 8, 2024
Merged
tasosbit pushed a commit to tasosbit/go-algorand-sdk that referenced this pull request Aug 29, 2024
@jannotti @d13co
Incentives: Add fields in block header for proposer and fees collecte…
fdcedea 
…d. (algorand#617)

* Add fields in block header for proposer and fees collected.
* Add payouts related fields to Account
* update consensus.go
* Add absent participation accounts
scholtz pushed a commit to scholtz/go-algorand-sdk that referenced this pull request Sep 15, 2024
@jannotti @scholtz
Incentives: Add fields in block header for proposer and fees collecte…
2a7a407 
…d. (algorand#617)

* Add fields in block header for proposer and fees collected.
* Add payouts related fields to Account
* update consensus.go
* Add absent participation accounts
scholtz added a commit to scholtz/go-algorand-sdk that referenced this pull request Sep 15, 2024
@scholtz @jasonpaulos
@gmalouf @jannotti @tianzedavid @github-actions @algo-dev-service @dependabot
rebase (#2)
966d6c3 
* Fix: Fix indexer sync issue in cucumber tests (algorand#628)

* Bump go version for builds/workflows to 1.20.14. (algorand#629)

* Incentives: Add fields in block header for proposer and fees collected. (algorand#617)

* Add fields in block header for proposer and fees collected.
* Add payouts related fields to Account
* update consensus.go
* Add absent participation accounts

* chore: fix function names (algorand#632)

Signed-off-by: tianzedavid <[email protected]>

* Regenerate code from specification file (algorand#631)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Fix funding for cucumber tests by rotating sender accounts (algorand#630)

* Build: Bump golang version to 1.21.10 (algorand#636)

* Bump golang version to 1.21.10

* Address new linter warnings.

* bump up version to v2.5.0

* Regenerate code from specification file (algorand#635)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Regenerate code from specification file (algorand#640)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Regenerate code from specification file (algorand#641)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Enable min-balance tests for indexer and algod APIs. (algorand#642)

* bump up version to v2.6.0

* Update .test-env to use Cucumber specs from master (algorand#645)

Update .test-env to use Cucumber specs from master rather than the now deprecated V2.

* Bump gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0 (algorand#605)

Bumps gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0.

---
updated-dependencies:
- dependency-name: gopkg.in/yaml.v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump golang.org/x/crypto (algorand#646)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210921155107-089bfa567519 to 0.17.0.
- [Commits](https://github.com/golang/crypto/commits/v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Regenerate code from specification file (algorand#647)

Co-authored-by: Algorand Generation Bot <[email protected]>

---------

Signed-off-by: tianzedavid <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jason Paulos <[email protected]>
Co-authored-by: Gary <[email protected]>
Co-authored-by: John Jannotti <[email protected]>
Co-authored-by: tianzedavid <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Algorand Generation Bot <[email protected]>
Co-authored-by: gmalouf <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees

@jannotti jannotti

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jannotti @jasonpaulos @cce