Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add min-balance to account information model #626

Conversation

kieranroneill
Copy link

Summary

Simply exposes the min-balance in the Account model as defined in the REST API response.

As the API defines the min-balance as required, there should always be a value. As of now (19th January 2024), minimum balance should always be >= 100,000 microAlgos.

Closes #272.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@gmalouf
Copy link
Contributor

gmalouf commented May 15, 2024

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

@kieranroneill
Copy link
Author

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

Hey @gmalouf I have updated the PR with the latest version :)

@gmalouf
Copy link
Contributor

gmalouf commented May 16, 2024

I jusr realized that the Account struct is actually generated based on the specification file in indexer using the sdk codegen
action that runs on this repository.

There is a draft PR open to add this: algorand/indexer#1596, I'm looking into what tests need to go in before moving forward.

@gmalouf gmalouf closed this May 16, 2024
@gmalouf
Copy link
Contributor

gmalouf commented May 23, 2024

#641 was just merged that addresses this (now that algorand/indexer#1596) was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose min-balance field in **Account Info**
3 participants