Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix funding for cucumber tests by rotating sender accounts #630

Merged
merged 1 commit into from
May 8, 2024

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Apr 29, 2024

Our integration tests have been failing with this message recently:

Feature: Indexer Client v2 Responses

--- Failed steps:

  Scenario: Simulating bad inner transactions in the ATC # features/integration/simulate.feature:84
    And I fund the current application's address with 10000000 microalgos. # features/integration/simulate.feature:99
      Error: HTTP 400: {"message":"TransactionPool.Remember: transaction EACAUS4SOXATJGT4L3GNPA4CYGZQPPY7HEZISHVHGECG7RIBQUQA: overspend (account AUTSR2JLL6WZT76LJDPLCWABDL7VGDJB7AIVNR3YE5V47VD6KGY2QGHH34, data {AccountBaseData:{Status:Not Participating MicroAlgos:{Raw:8759477} RewardsBase:0 RewardedMicroAlgos:{Raw:0} AuthAddr:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ IncentiveEligible:false TotalAppSchema:{_struct:{} NumUint:0 NumByteSlice:0} TotalExtraAppPages:0 TotalAppParams:0 TotalAppLocalStates:0 TotalAssetParams:0 TotalAssets:0 TotalBoxes:0 TotalBoxBytes:0 LastProposed:0 LastHeartbeat:0} VotingData:{VoteID:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] SelectionID:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] StateProofID:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] VoteFirstValid:0 VoteLastValid:0 VoteKeyDilution:0}}, tried to spend {10000000})"}



71 scenarios (70 passed, 1 failed)
1293 steps (1272 passed, 1 failed, 20 skipped)

Example: https://app.circleci.com/pipelines/github/algorand/go-algorand-sdk/1211/workflows/86f710d6-8844-450e-a730-b8af05f95ca0/jobs/2585

This PR attempts to solve the issue by drawing algos from all of the accounts (I believe there are 3 or 4 available) instead of always using the same account.

@jasonpaulos jasonpaulos marked this pull request as ready for review April 29, 2024 16:44
@jasonpaulos jasonpaulos self-assigned this Apr 29, 2024
@jasonpaulos jasonpaulos requested a review from cce April 29, 2024 16:47
@jasonpaulos jasonpaulos requested a review from gmalouf May 8, 2024 18:32
@gmalouf gmalouf merged commit dde38d8 into develop May 8, 2024
6 of 7 checks passed
@gmalouf gmalouf deleted the cucumber-test-funding-fix branch May 8, 2024 18:34
tasosbit pushed a commit to tasosbit/go-algorand-sdk that referenced this pull request Aug 29, 2024
scholtz pushed a commit to scholtz/go-algorand-sdk that referenced this pull request Sep 15, 2024
scholtz added a commit to scholtz/go-algorand-sdk that referenced this pull request Sep 15, 2024
* Fix: Fix indexer sync issue in cucumber tests (algorand#628)

* Bump go version for builds/workflows to 1.20.14. (algorand#629)

* Incentives: Add fields in block header for proposer and fees collected. (algorand#617)

* Add fields in block header for proposer and fees collected.
* Add payouts related fields to Account
* update consensus.go
* Add absent participation accounts

* chore: fix function names (algorand#632)

Signed-off-by: tianzedavid <[email protected]>

* Regenerate code from specification file (algorand#631)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Fix funding for cucumber tests by rotating sender accounts (algorand#630)

* Build: Bump golang version to 1.21.10 (algorand#636)

* Bump golang version to 1.21.10

* Address new linter warnings.

* bump up version to v2.5.0

* Regenerate code from specification file (algorand#635)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Regenerate code from specification file (algorand#640)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Regenerate code from specification file (algorand#641)

Co-authored-by: Algorand Generation Bot <[email protected]>

* Enable min-balance tests for indexer and algod APIs. (algorand#642)

* bump up version to v2.6.0

* Update .test-env to use Cucumber specs from master (algorand#645)

Update .test-env to use Cucumber specs from master rather than the now deprecated V2.

* Bump gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0 (algorand#605)

Bumps gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0.

---
updated-dependencies:
- dependency-name: gopkg.in/yaml.v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump golang.org/x/crypto (algorand#646)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210921155107-089bfa567519 to 0.17.0.
- [Commits](https://github.com/golang/crypto/commits/v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Regenerate code from specification file (algorand#647)

Co-authored-by: Algorand Generation Bot <[email protected]>

---------

Signed-off-by: tianzedavid <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jason Paulos <[email protected]>
Co-authored-by: Gary <[email protected]>
Co-authored-by: John Jannotti <[email protected]>
Co-authored-by: tianzedavid <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Algorand Generation Bot <[email protected]>
Co-authored-by: gmalouf <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants