Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incentives: Suspend "absentee" accounts that don't propose. #5757

Merged
merged 123 commits into from
Apr 23, 2024
Merged

Incentives: Suspend "absentee" accounts that don't propose. #5757

merged 123 commits into from
Apr 23, 2024

Commits on Jan 16, 2024

  1. Implements "Mining" - diverting a portion of fees to proposers

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a6a51db View commit details
    Browse the repository at this point in the history

  2. Add min and max to receive block incentives

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    84ee996 View commit details
    Browse the repository at this point in the history

  3. Stop checking for incentive payouts in e2e subs.

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c3bc1c8 View commit details
    Browse the repository at this point in the history

  4. Add IncentiveEligible field to accounts.

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1d9b337 View commit details
    Browse the repository at this point in the history

  5. Maintain and use the acct.Incentiveligible flag

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1993a9f View commit details
    Browse the repository at this point in the history

  6. Test assembly of new block fields

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b717df6 View commit details
    Browse the repository at this point in the history

  7. year

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    00de010 View commit details
    Browse the repository at this point in the history

  8. it's v11 now

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1aa9072 View commit details
    Browse the repository at this point in the history

  9. Adds LastProposed fields, and logic for checking absenteeism 

    Make migrate use VoteID.IsEmpty()
Improve random accounts, especially for basics.Suspended
Validate proposed absents, and suspend them.
    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    854d149 View commit details
    Browse the repository at this point in the history

  10. Remove basics.Suspended as an explicit account state 

    v40

Use SelectionID to detect when to zero out StateProofID

Simplify online account delta handling

Fix expiration test
    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    cd40d74 View commit details
    Browse the repository at this point in the history

  11. Go e2e test showing suspension and proposal to come back online

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8a6bc20 View commit details
    Browse the repository at this point in the history

  12. If a suspended account proposes, bring it back online.

    @jannotti
    jannotti committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    49c24de View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Suspensions turns off IncentiveEligible

    @jannotti
    jannotti committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    be105aa View commit details
    Browse the repository at this point in the history

  2. Don't consider pre-existing accounts absent

    @jannotti
    jannotti committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b6578aa View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge remote-tracking branch 'upstream/master' into absenteeism-2

    @jannotti
    jannotti committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f7b87bb View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Perform bonus payments, with exponential decay

    @jannotti
    jannotti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    09f72db View commit details
    Browse the repository at this point in the history

  2. Show node can re-reg to become incentive eligible again

    @jannotti
    jannotti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cce9432 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Typo level fixes

    @jannotti
    jannotti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    7e0d283 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Make test (almost) unflakable

    @jannotti
    jannotti committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8b7946f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Some CR updates

    @jannotti
    jannotti committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1996bce View commit details
    Browse the repository at this point in the history

  2. Remove WithSeed from non-validated Block 

    It was confusing
    @jannotti
    jannotti committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2c5a66a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Implement "challenges"

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ba42ba8 View commit details
    Browse the repository at this point in the history

  2. CR fixes

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    06c10c1 View commit details
    Browse the repository at this point in the history

  3. Add BlkBonus assembly test

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    794dcea View commit details
    Browse the repository at this point in the history

  4. Account for new fields in header

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ee9a623 View commit details
    Browse the repository at this point in the history

  5. Simplify decay code, show first year behaviour

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    59b4f98 View commit details
    Browse the repository at this point in the history

  6. forgotten partitiontest

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    1f3e485 View commit details
    Browse the repository at this point in the history

  7. Completed a comment

    @jannotti
    jannotti committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    eb923da View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Tidying and testing

    @jannotti
    jannotti committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b2f7691 View commit details
    Browse the repository at this point in the history

  2. bonus rate change tests

    @jannotti
    jannotti committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    80410fe View commit details
    Browse the repository at this point in the history

  3. Turn on block bonuses in vFuture

    @jannotti
    jannotti committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b69c021 View commit details
    Browse the repository at this point in the history

  4. Relocate suspension_test.go to prep for adding similar incentives

    @jannotti
    jannotti committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fd4ccaf View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Add e2e test for mining and bonuses

    @jannotti
    jannotti committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3959e1d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. pass up the error

    @jannotti
    jannotti committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    bb401cf View commit details
    Browse the repository at this point in the history

  2. WithSeed -> WithProposal

    @jannotti
    jannotti committed Feb 5, 2024
    1 Configuration menu
    Copy the full SHA
    316083f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Many CR changes, most notably using consensus params

    @jannotti
    jannotti committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    46470f7 View commit details
    Browse the repository at this point in the history

  2. Missed a change

    @jannotti
    jannotti committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    762a77a View commit details
    Browse the repository at this point in the history

  3. Better comment about overflow

    @jannotti
    jannotti committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a05e317 View commit details
    Browse the repository at this point in the history

  4. Lint related comments

    @jannotti
    jannotti committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c0cfdef View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. ok reviewdog, you win

    @jannotti
    jannotti committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c26ca5b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. CR changes 

    Moved challenge constant into mining rules.

Don't let challenges cross upgrades.

Better unit testing of small eval.go functions.
    @jannotti
    jannotti committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0ed15ec View commit details
    Browse the repository at this point in the history

  2. Some missed function parameter changes

    @jannotti
    jannotti committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    23b12cf View commit details
    Browse the repository at this point in the history

  3. spelling

    @jannotti
    jannotti committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5743edf View commit details
    Browse the repository at this point in the history

  4. missing word 

    Co-authored-by: Jason Paulos <[email protected]>
    @jannotti @jasonpaulos
    jannotti and jasonpaulos committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    69c982e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Adjust test for bonus payout

    @jannotti
    jannotti committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    8aa85e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Record the block payout explicitly 

    Add ProposerPayout to the block header to make it very clear how much
will be moved from the feesink to the proposer.

It is tentatively recorded during block evaluation, but agreement can
zero out the payment because it is only in the agreement code that the
actual proposer is known - so it can be checked for eligibility.
    @jannotti
    jannotti committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    64b2103 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fixups for moving some functionality to agreemnet

    @jannotti
    jannotti committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    34f1ede View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. max size change for proposerPayout

    @jannotti
    jannotti committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    693ba61 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Correctly learn consensus params for current proposal.

    @jannotti
    jannotti committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6db9d51 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Fixups to get the separation between eval and agreement right

    @jannotti
    jannotti committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4eac136 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Don't ignore err

    @jannotti
    jannotti committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    44d120f View commit details
    Browse the repository at this point in the history

  2. Fixup ledger tests for proposer presence

    @jannotti
    jannotti committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    43940e9 View commit details
    Browse the repository at this point in the history

  3. comment wording

    @jannotti
    jannotti committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dfe7bb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. feature flag the header properly

    @jannotti
    jannotti committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bee6bdd View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Comment change and pointless code removal

    @jannotti
    jannotti committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    aee989c View commit details
    Browse the repository at this point in the history

  2. Fix unit test for eligibility test in blance round

    @jannotti
    jannotti committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a8c1d9b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. suspension test updates

    @jannotti
    jannotti committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7abf6b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Reduce duplicative calls

    @jannotti
    jannotti committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7dbd497 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Comment clarification 

    Co-authored-by: cce <[email protected]>
    @jannotti @cce
    jannotti and cce committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    13af5f0 View commit details
    Browse the repository at this point in the history

  2. sanity check 

    Co-authored-by: cce <[email protected]>
    @jannotti @cce
    jannotti and cce committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0aa7d5f View commit details
    Browse the repository at this point in the history

  3. CR updates

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c49946f View commit details
    Browse the repository at this point in the history

  4. Absent list generation tests

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    76af3a3 View commit details
    Browse the repository at this point in the history

  5. Add methods for some reason

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a61a0ef View commit details
    Browse the repository at this point in the history

  6. WithProposER

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    74ede81 View commit details
    Browse the repository at this point in the history

  7. Copy IncentiveEligible in ledgercore function

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fd1c88b View commit details
    Browse the repository at this point in the history

  8. comment updates

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9d536a7 View commit details
    Browse the repository at this point in the history

  9. More explicitly set the returned stackValue

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a7e7010 View commit details
    Browse the repository at this point in the history

  10. more friendly fire from adding methods

    @jannotti
    jannotti committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1b0d633 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Move the mining and bonus stuff into consensus 

    also, removing the name "mining" in favor of just "payouts"
    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    f64c143 View commit details
    Browse the repository at this point in the history

  2. lint docs

    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    53b9cca View commit details
    Browse the repository at this point in the history

  3. spelling

    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    613d7d4 View commit details
    Browse the repository at this point in the history

  4. make msgp

    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    961ae74 View commit details
    Browse the repository at this point in the history

  5. collateral damage

    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    88e7192 View commit details
    Browse the repository at this point in the history

  6. Remove "mining" wording from comments and variable names

    @jannotti
    jannotti committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1ec4f31 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. func, field, whatever

    @jannotti
    jannotti committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    dcb4636 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Pass the actual proposer into payoutEligible, even before payouts 

    Doing so allows the propoer record to be returned.
    @jannotti
    jannotti committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    648f95e View commit details
    Browse the repository at this point in the history

  2. Trying to track down a failure

    @jannotti
    jannotti committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9c8211c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. split ValidatedBlock and AssembledBlock interfaces

    @cce
    cce committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c054b3c View commit details
    Browse the repository at this point in the history

  2. fix new tests

    @cce
    cce committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6305819 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. checkpoint better testing before n+1 to n

    @jannotti
    jannotti committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    216ea21 View commit details
    Browse the repository at this point in the history

  2. bonus constant changes

    @jannotti
    jannotti committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e0658cd View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Make the proposer payouts happen in same block they are proposed.

    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b3c26ca View commit details
    Browse the repository at this point in the history

  2. No idea why this is failing

    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    73798d1 View commit details
    Browse the repository at this point in the history

  3. Don't save the deltas after generating a proposal 

    Those deltas are incomplete, don't cache and use them.
    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a914ee1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'absenteeism' into absenteeism-split-assembledblock

    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    e82769e View commit details
    Browse the repository at this point in the history

  5. Merge pull request #19 from cce/absenteeism-split-assembledblock 

    agreement: split ValidatedBlock and AssembledBlock interfaces
    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    0ef3056 View commit details
    Browse the repository at this point in the history

  6. correct type in merge conflict resolution

    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4e2313a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into absenteeism

    @jannotti
    jannotti committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    82263e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. first step of applying unfinishedBlock changes from algorand#5967 to a… 

    …lgorand#5757
    @cce
    cce committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2c40125 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. add ledgercore.UnfinishedBlock and provide VotingAccountChecker to tr… 

    …ansactionPool
    @cce
    cce committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f2c4f29 View commit details
    Browse the repository at this point in the history

  2. wire up ledgercore.UnfinishedBlock to node AssembleBlock implementati… 

    …on, and update tests that call GenerateBlock
    @cce
    cce committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    43f74e5 View commit details
    Browse the repository at this point in the history

  3. fix tests & generator

    @cce
    cce committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0e3034a View commit details
    Browse the repository at this point in the history

  4. update remaining broken tests to use GenerateBlock and MakeValidatedB… 

    …lock
    @cce
    cce committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5dbe3c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. move MakeAccountManager to be above MakeTransactionPool

    @cce
    cce committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b7c7fe0 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. CR changes

    @jannotti
    jannotti committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8893086 View commit details
    Browse the repository at this point in the history

  2. rename VotingAccountChecker => Supplier

    @cce
    cce committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    906c8aa View commit details
    Browse the repository at this point in the history

  3. rename ue, ve, to ub, pb

    @cce
    cce committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d8ad692 View commit details
    Browse the repository at this point in the history

  4. don't assign ProposableBlock to ValidatedBlock in agreement tests

    @cce
    cce committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6551096 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge remote-tracking branch 'cce/absenteeism-unfinishedblock' into a… 

    …bsenteeism
    @jannotti
    jannotti committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7ac7e00 View commit details
    Browse the repository at this point in the history

  2. Don't pay closed proposers.

    @jannotti
    jannotti committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    72957a0 View commit details
    Browse the repository at this point in the history

  3. linter

    @jannotti
    jannotti committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    569a48e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Prevent payouts to closed account

    @jannotti
    jannotti committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6bff639 View commit details
    Browse the repository at this point in the history

  2. Fixup for rule that proposer must exist to be paid

    @jannotti
    jannotti committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    aceef41 View commit details
    Browse the repository at this point in the history

  3. Insert paranoid debug check to investivate failure in CI

    @jannotti
    jannotti committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6540c05 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. very old typo fix

    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    73fff7b View commit details
    Browse the repository at this point in the history

  2. Pavel CR

    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    82e244d View commit details
    Browse the repository at this point in the history

  3. explain the paranoia differently after interface changes

    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c27f7b3 View commit details
    Browse the repository at this point in the history

  4. Tidy up endOfBlock()

    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    58a70e6 View commit details
    Browse the repository at this point in the history

  5. Reduce "shim types", introduce agreement.Block 

    agreement.Block is similar to what was agreement.ProposableBlock, but
rather than being an interface it is a concrete type.  Therefore,
there can be no confusion: A validated block is not an agreement.Block
just because it has a Block() method.

Instead, FinalizeBlock methods explicit copy their internal Block()
objects into agreement.Block objects during finalization.

This PR also eliminates node.validatedBlock as
*ledgercore.ValidatedBlock implements agreement.ValidatedBlock
already, no wrapper is needed.  Blocks remain as immutable as before.
    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a46890d View commit details
    Browse the repository at this point in the history

  6. Removed XXX in favor of explaining that we are skipping agreement

    @jannotti
    jannotti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8baf0f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. CR cleanup

    @jannotti
    jannotti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7b1560d View commit details
    Browse the repository at this point in the history

  2. Make it clearer where the delays come from

    @jannotti
    jannotti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    015379b View commit details
    Browse the repository at this point in the history

  3. mining -> payouts

    @jannotti
    jannotti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e0c5d4f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Leave lookback at 320 for suspension test 

    Part of the test requires the suspended node to re-propose after
suispension. That can only happen when the balance lookback is
considerably bigger than the suspension interval (here, 5*10==50)

Fortunately, this test doesn't have to wait for lookback, so the
benefit of short filter timeout is all we need for a quick test.
    @jannotti
    jannotti committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f1082f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge pull request #21 from jannotti/agreement-block 

    Reduce "shim types", introduce agreement.Block
    @jannotti
    jannotti committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0265066 View commit details
    Browse the repository at this point in the history

  2. Accomodate talking to slow clients

    @jannotti
    jannotti committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ba5efda View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. add mismatched proposer check to increase coverage a tiny bit

    @cce
    cce committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    40ce14a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Batch of comment tweaks from CR

Co-authored-by: Jason Paulos <[email protected]>
    @cce @jasonpaulos
    cce and jasonpaulos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1037ad5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. exercise inability to pay from fee sink

    @jannotti
    jannotti committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    87a20c5 View commit details
    Browse the repository at this point in the history

  2. Simplifiy tests. No "current" test, and no mockBalances

    @jannotti
    jannotti committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7ddccf3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Typo 

    Co-authored-by: cce <[email protected]>
    @jannotti @cce
    jannotti and cce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    480f0f9 View commit details
    Browse the repository at this point in the history

  2. comment 

    Co-authored-by: cce <[email protected]>
    @jannotti @cce
    jannotti and cce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    762e15b View commit details
    Browse the repository at this point in the history

  3. Ensure only the address we thought would get suspended did. 

    Co-authored-by: cce <[email protected]>
    @jannotti @cce
    jannotti and cce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3d2fbc4 View commit details
    Browse the repository at this point in the history