Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: network: fix p2p received_{bytes, messages}_TX metrics #6144

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

fix metrics diff plotter

8fec6f8
Select commit
Loading
Failed to load commit list.
Draft

WIP: network: fix p2p received_{bytes, messages}_TX metrics #6144

fix metrics diff plotter
8fec6f8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 27, 2024 in 1s

56.25% (-0.01%) compared to 8b6c443, passed because coverage increased by 0% when compared to adjusted base (56.25%)

View this Pull Request on Codecov

56.25% (-0.01%) compared to 8b6c443, passed because coverage increased by 0% when compared to adjusted base (56.25%)

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (8b6c443) to head (8fec6f8).

Files with missing lines Patch % Lines
network/metrics.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6144      +/-   ##
==========================================
- Coverage   56.25%   56.25%   -0.01%     
==========================================
  Files         494      494              
  Lines       69946    69948       +2     
==========================================
+ Hits        39350    39351       +1     
- Misses      27919    27920       +1     
  Partials     2677     2677              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.