Unexpected Limit behavior

[barnjamin]

Subject of the issue

Reported in Discord

Currently the following produces somewhat surprising results

https://testnet-idx.algonode.cloud/v2/applications/83648221/logs?limit=500
https://testnet-idx.algonode.cloud/v2/applications/83648221/logs?limit=1

Where limit 1 returns no results.

I believe this is because the transaction search applies the limit and the filter here:

https://github.com/algorand/indexer/blob/develop/api/handlers.go#L542-L550

further limits the result set, so the limit is how many rows to retrieve in the db rather than the actual limit of log values to get back.

Acceptance Criteria

• The root cause of this is likely the way we handle client side filtering, and is not limited to just the logs.
• Design a solution, and/or update documentation to reflect the expected behavior.
  • we could document that you should continue paging.
  • we could automatically run multiple queries.
  • we could avoid client side filtering.

[liamvuverdex]

Thank you for submitting this for me, @barnjamin.