Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application call accounts to txn_participation table #768

Closed
tolikzinovyev opened this issue Nov 3, 2021 · 2 comments · Fixed by #770
Closed

Add application call accounts to txn_participation table #768

tolikzinovyev opened this issue Nov 3, 2021 · 2 comments · Fixed by #770
Assignees

Comments

@tolikzinovyev
Copy link
Contributor

Subject of the issue

We currently add the following to the txn_participation table: sender, receiver, close address, asset sender, asset receiver, asset close address, freeze account. However, we are missing Transaction.ApplicationCallTxnFields.Accounts which are the accounts referenced in an application call. In the future, we might want to construct queries that need this information (e.g., get app call transactions that reference a particular address).

@gmalouf
Copy link
Contributor

gmalouf commented Nov 3, 2021

@winder I remember us discussing storing inner transactions at the same level as outer ones to facilitate searches (with appropriate ref txids, table separation, etc). Did that work ever end up finishing or was it paused?

@winder
Copy link
Contributor

winder commented Nov 3, 2021

@winder I remember us discussing storing inner transactions at the same level as outer ones to facilitate searches (with appropriate ref txids, table separation, etc). Did that work ever end up finishing or was it paused?

@gmalouf Yes, that work was finished. It's not really related to this issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants