Add account min balance field #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
force-pushed
the
account-min-balance
branch
from
5ce3a09
to
7d2f55e
Compare
gmalouf
force-pushed
the
account-min-balance
branch
from
7d2f55e
to
175cdb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
+ Coverage 68.54% 68.80% +0.25%
==========================================
Files 37 38 +1
Lines 7452 7517 +65
==========================================
+ Hits 5108 5172 +64
- Misses 1914 1915 +1
Partials 430 430 ☔ View full report in Codecov by Sentry. |
jasonpaulos
commented
May 22, 2024
algorandskiy
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the minimum balance field to accounts returned over the REST API.
Fixes #808
Test Plan
Added a minBalance unit test exercising the core minBalance formula (parallels that in go-algorand).