Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish v3 release #824

Closed
1 of 9 tasks
jasonpaulos opened this issue Sep 8, 2023 · 1 comment
Closed
1 of 9 tasks

Finish v3 release #824

jasonpaulos opened this issue Sep 8, 2023 · 1 comment

Comments

@jasonpaulos
Copy link
Contributor

jasonpaulos commented Sep 8, 2023

This issue outlines all remaining work that's necessary to release v3 of this library (which is currently in development in #817)

  • Bigints should be used by default for REST API decoding
  • Transaction and related classes must be updated to accept bigints for all numeric fields
  • Remove ability to pass raw objects as transactions to functions (tech debt, and solves Replace instanceof checks with other type check  #740)
  • Update BlockHeader class to have accurate types
  • Look into inline response type support in the REST API
  • Should indexer responses also be typed?
  • Update ESM bundle support to adhere to modern standards (Native ESM #819). For the time being, we want to continue supporting commonjs and ESM, but our ESM support has fallen behind current practices.
  • Update SourceMap class to map columns (TEAL Source Map: Improve SourceMap and support columns #834)
  • EncodedSignedTransaction is not properly decoded from REST API -- binary fields are typed as Uint8Array but left as base64 strings when coming from JSON

#816 has been opened as an attempt to address most of these issues

@paulmillr
Copy link

paulmillr commented Sep 24, 2023

Thoughts on the security improvement? #742

It should take about 0.5-1 hour of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants