Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove int decoding option, support bigint by default #848

Closed
jasonpaulos opened this issue Jan 3, 2024 · 0 comments
Closed

Remove int decoding option, support bigint by default #848

jasonpaulos opened this issue Jan 3, 2024 · 0 comments

Comments

@jasonpaulos
Copy link
Contributor

Remove the IntDecoding enum option on REST API calls. This option was originally introduced to allow bigints to be decoded by the REST API in a backwards-compatible way, but it's no longer needed in v3.

Instead, we should decode with support for bigints by default (either by upgrading every int to a bigint or only those which exceed Number.MAX_SAFE_INTEGER). The algod and indexer REST API specs should indicate which fields actually need to be represented by a uint64 or larger with the "x-algorand-format": "uint64" value; these can be typed as bigint by this SDK, and the rest can remain numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant