Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction and Signatures pages lack information on field ordering and encoding requirements #814

Open
FrankSzendzielarz opened this issue May 10, 2022 · 1 comment
Labels
minor update Any small code or wording update.

Comments

@FrankSzendzielarz
Copy link

Describe the error
The Transaction reference and structure pages, and Signature page, omit that transaction field ordering is important for computing the signature and transaction id. Field ordering is not important for the Transaction message POSTed to the network however.

Link to the page or line
Transactions page

Optional - The recommended fix if you have one
Dedicated info on how to form the message, with a 'canonical messagepack' encoding for signature/id computation.

@FrankSzendzielarz FrankSzendzielarz added the minor update Any small code or wording update. label May 10, 2022
@FrankSzendzielarz
Copy link
Author

Hi there @kelvinDev67 thanks, I don't need to - I've been talking already on Discord. My feedback is that the docs lack that information. If there is going to be information about manual transaction construction and transaction structure, then in it's present form it is incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor update Any small code or wording update.
Projects
None yet
Development

No branches or pull requests

3 participants
@FrankSzendzielarz and others