Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biz exceptions should be recorded on entry completed #1419

Closed
sczyh30 opened this issue Apr 21, 2020 · 0 comments · Fixed by #1420
Closed

Biz exceptions should be recorded on entry completed #1419

sczyh30 opened this issue Apr 21, 2020 · 0 comments · Fixed by #1420
Assignees
@sczyh30
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
1.8.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented Apr 21, 2020

Issue Description

Type: enhancement

Describe what happened (or what feature you want)

Biz exceptions should be recorded on entry completed (i.e. exit), rather than immediately after calling Tracer.traceEntry(ex, e), so that the statistic data could be more accurate.
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Apr 21, 2020
@sczyh30 sczyh30 self-assigned this Apr 21, 2020
@sczyh30 sczyh30 mentioned this issue Apr 21, 2020
Merged
@sczyh30 sczyh30 added this to the 1.8.0 milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczyh30 sczyh30

Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Refactor the mechanism of recording error (on completed) sczyh30/Sentinel
1 participant
@sczyh30