[Nodes] Add a new 'enabled' property to node's attributes #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new property "enabled" allows to define a lambda to dynamically enable/disable parameters. Disabled parameters are not used in the uid, not exported to the command line and not visible in the interface.
|
As disabled params will not be used anymore in the UID, it will change all the invalidation, so you need to increment the major version of each modified node. |
fabiencastan
requested changes
Jul 29, 2020
Params are only used on drag&drop and do not invalidate the node computation. Only Viewpoints and Intrinsics are now used in the invalidation.
fabiencastan
added
the
feature
fabiencastan
approved these changes
Jul 29, 2020
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'enabled' is a new parameter for the node's attributes. It allows to enable/disable the attribute. If it is disabled, the attribute will not be displayed inside the UI and will not be sent to the command line.
This is quite useful when an attribute is used only if another is checked, for instance.
'enabled' can receive either a boolean or a lambda function.