Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features Viewer #539

Merged
merged 6 commits into from
Jul 25, 2019
Merged

Features Viewer #539

merged 6 commits into from
Jul 25, 2019

Conversation

yann-lty
Copy link
Member

@yann-lty yann-lty commented Jul 4, 2019 •
edited
Loading

Description

Based on QtAliceVision plugin, provide a viewer for extracted feature points within the 2D Image Viewer.

features

  • Provides 3 visualization modes: Points, (scaled) Squares, Orientated Squares
  • FeatureExtraction nodes can be double clicked to drive which node is used for the FeaturesViewer
  • Component is loaded dynamically to evaluate QtAliceVision plugin availability - an error is displayed if the plugin fails to load:
    image
  • A picker with a predefined palette is available to select feature points colors
    featcolors

@yann-lty
[ui] Reconstruction: rename 'endNode' to 'texturing'
00857a7 
+ use makeProperty helper
@yann-lty
[ui] Reconstruction: improve constructor readability
a358c46
@yann-lty
[ui] Reconstruction: add 'featureExtraction' member
4435ba9 
* add featureExtraction property to keep track of current FeatureExtraction node 
* update it when current CameraInit node is changed
* allow to set current CameraInit by double clicking on a CameraInit node from the Graph Editor
@yann-lty
[ui] New FeaturesViewer component
8dd0a4b 
FeaturesViewer wraps QtAliceVision plugin's FeaturesViewer component to display the extracted feature points of a View.
@yann-lty
[ui] Viewer2D: add FeaturesViewer + dedicated overlay
4563d32 
Make FeaturesViewer available in Viewer2D to display the feature points of the current view, based on the current FeatureExtraction node.

* FeaturesInfoOverlay: overlay that displays info and provides controls over a FeaturesViewer component.
* ColorChart: color picker based on a set of predefined colors.
@natowi natowi mentioned this pull request Jul 4, 2019
Open
@ChemicalXandco
Copy link
Contributor

Is meshroom still supporting Qt 5.11? This addition makes error when using Qt 5.11: meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml:2 module "QtQuick.Controls" version 2.11 is not installed
This is very good feature btw!

@yann-lty
Copy link
Member Author

yann-lty commented Jul 4, 2019 •
edited
Loading

Thanks for the feedback!
Yes 5.11 is still supported for now, you can lower the version of imported QtQuick Controls (I was working with 5.13 and did not paid enough attention to modules versions here).
But the goal is to move on to 5.13 really soon to be able to benefit from the improvement made to the JS engine (ES7) and some of the new controls (like the new SplitView in QuickControls 2.x).
Were you able to build the QtAliceVision C++ plugin without issues ?

@ChemicalXandco
Copy link
Contributor

ChemicalXandco commented Jul 4, 2019 •
edited
Loading

Sounds good! I am to compiling QtAliceVision at the moment, I will report back if it is working or not for me.

Edit: I do not have time to compile for the time being, because Qt is a very big software.

@natowi natowi mentioned this pull request Jul 5, 2019
Closed
@fabiencastan fabiencastan modified the milestone: Meshroom 2019.2.0 Jul 5, 2019
@fabiencastan fabiencastan merged commit 059ca36 into develop Jul 25, 2019
@fabiencastan fabiencastan deleted the dev/featuresViewer branch July 25, 2019 18:58
@natowi natowi mentioned this pull request Aug 25, 2019
Closed
@simogasp simogasp added the feature new feature (proposed as PR or issue planned by dev) label Sep 13, 2019
@fabiencastan fabiencastan mentioned this pull request Sep 22, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature new feature (proposed as PR or issue planned by dev)
Projects
None yet
Milestone
Meshroom 2019.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yann-lty @ChemicalXandco @fabiencastan @simogasp