Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to load depth maps into 2D and 3D Viewers within meshroom #657

Closed
wants to merge 76 commits into from
Closed

Ability to load depth maps into 2D and 3D Viewers within meshroom #657

wants to merge 76 commits into from

Conversation

ChemicalXandco
Copy link
Contributor

@ChemicalXandco ChemicalXandco commented Sep 25, 2019 •
edited
Loading

Description

A better approach to #650

Features list

  • Combo box to select image type (image, depthMap, simMap)
  • Button to view depth map of the current image in the 3D viewer
  • Active node that can be either DepthMap or DepthMapFilter

Implementation remarks

DepthMap and DepthMapFilter are treated the same to avoid extra complexity
I haven't included nModMap because it does not seem to be important

mike1158 and others added 29 commits August 26, 2019 09:37
@mike1158
Bugfix for MESHROOM_SUBMITTERS_PATH env variable
44779f6 
Setting MESHROOM_SUBMITTERS_PATH caused meshroom to try to load the bundled
simpleFarmSubmitter plugin twice, ignoring the path in the variable.

I believe the problem lies with the way loadPlugins() works in meshroom.core,
because it's trying to import the package name "submitters" more than once.  The
second time, import_module() just returns a reference to the

This is a revised PR based on feedback from the first one I submitted last year,
which went stale and then got erased as I was stumbling my way through git.
@ToukL @fabiencastan
[nodes][aliceVision] New node for hdri panorama stitching
bd88d16
@fabiencastan
[nodes] New GlobalSfM node
7fc3d50
@fabiencastan
[nodes] New Panorama estimation node
0cdb193
@fabiencastan
[nodes] split Panorama into PanoramaEstimation and PanoramaStitching
fad4d53
@fabiencastan
[nodes] PanoramaStitching: add a new debug param
36b591f
@fabiencastan
[nodes] PanoramaEstimation: declare a param as "advanced"
e7022f0
@fabiencastan
[nodes] PanoramaStitching: add a new debug option
2862458
@fabiencastan
[ui] WorkspaceView: open images in the 2D Viewer from the Graph/NodeE…
ade9360 
…ditor

Double click on a node or an attribute with an image file to display it
in the 2D viewer.
@fabiencastan
[nodes] Panorama: new param "refine"
b87432f
@fabiencastan
[nodes] new debug node: ExportMatches
38d27c9
@ChemicalXandco
Merge pull request #5 from alicevision/develop
378b142 
Latest changes
@ChemicalXandco
[ui] Reconstruction: add 'depthMap' member
704be1e
@ChemicalXandco
add ComboBox to select depth map file
f118bb9
@ChemicalXandco
add button on 2D Viewer to view depth maps in the 3D Viewer
ef4b350
@ChemicalXandco
Merge branch 'pr/6' into view_depthmaps2
b8a13d1
@servantftechnicolor
adding a node for rotating head xml
ee6772b
@servantftechnicolor
restart stitching
77b867c
@servantftechnicolor
Control panorama width
e97676f
@servantftechnicolor @fabiencastan
Make a compatible LDRToHDR node
9d78c7b
@fabiencastan
[nodes] LDR2HDR: resize dynamic node size based on groupSize param
54a57a7
@fabiencastan
Merge branch 'develop' of https://github.com/alicevision/meshroom int…
ff9b0e6 
…o dev_hdriStitching
@fabiencastan
Merge branch 'develop' of https://github.com/alicevision/meshroom int…
a85730a 
…o dev_hdriStitching
@fabiencastan
[bin] meshroom: option to choose HDRI pipeline
07f564d
@fabiencastan
[multiview] setup xml files to Panorama node, create KeyframeSelectio…
f03b52e 
…n for video files
@servantftechnicolor
Adding node for camera downscale
00e9067
@fabiencastan
[nodes] LDRToHDR: expose more options
45efa8b
@fabiencastan
Merge branch 'dev_hdriStitching' of https://github.com/alicevision/Me…
a4f1d84 
…shroomPrivate into dev_hdriStitching
@servantftechnicolor
Splitting compositing and warping
8b34d08
@natowi
Copy link
Member

natowi commented Nov 16, 2019

Thank you for this feature, it works well.
Only setting the Display Trackball does not work as reliably as with the point cloud or mesh. You sometimes need to click multiple times in an area to set the new rotation point.

fabiencastan and others added 24 commits December 16, 2019 12:38
@fabiencastan
[nodes] LDRToHDR: add automatic detection of the number of brackets
cbb176d
@fabiencastan
[nodes] Panorama: minor fix to compositerType default value
e0f4fcb
@fabiencastan
[bin] photogrammetry: reduce the number of updates with "GraphModific…
9775924 
…ation" group
@fabiencastan
[nodes] CameraInit: remove subprocess wait (communicate is enough)
69a1f15
@fabiencastan
[ui] set AA_EnableHighDpiScaling earlier to fix qt warnings
be0fb57
@fabiencastan
[nodes] LDRToHDR: declare cpu/ram usages
25127bb
@fabiencastan
Merge pull request #610 from mike1158/develop
ff96004 
Bugfix for MESHROOM_SUBMITTERS_PATH env variable
@ChemicalXandco
use Filepath.stringToUrl instead of "file:///"+
bfc901a
@fabiencastan
Merge pull request #639 from alicevision/dev_hdriStitching
44901f0 
360 HDR creation
@cvere @fabiencastan
[Texturing] add options for retopoMesh & reorganise options
b214584
@fabiencastan
[nodes] Texturing: rename subdivision parameters
35258ac
@fabiencastan
[nodes] Texturing: simplify subdivision parameters
1814a34
@fabiencastan
[nodes] Texturing: correctEV param is now visible
30f902b
@fabiencastan
Merge pull request #571 from alicevision/dev/texturing_retopomesh
2beb349 
[Texturing] add options for retopoMesh & reorganise options
@fabiencastan
[ui] fix import of images from command line
2431b53
@fabiencastan
[ui] add option to save the new project file from the command line
a0d6d23
@fabiencastan
[ui] command line: add support for filepath expressions in input
c82084a
@fabiencastan
[ui] add verbose option
b244e2e
@fabiencastan
Merge pull request #759 from alicevision/dev/commandline
7b3ae2f 
Command line adjustments
@fabiencastan
Merge branch 'view_depthmaps2' of https://github.com/ChemicalXandco/m…
e6e3a78 
…eshroom into ChemicalXandco-view_depthmaps2
@fabiencastan
[ui] viewer: move depthmap to 3D to the right and remove "Map" from c…
64befd2 
…ombobox
@fabiencastan
[ui] reset depthmap node when camerainit change
dfdd281
@fabiencastan
[ui] minor qml warning fix
6210a71
@fabiencastan
[ui] Viewer: use label for DepthMap node instead of name
415cf50
@fabiencastan fabiencastan mentioned this pull request Jan 24, 2020
Merged
@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Jan 24, 2020
@fabiencastan
Copy link
Member

Merged in #769.

@ChemicalXandco ChemicalXandco deleted the view_depthmaps2 branch June 20, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-lty yann-lty Awaiting requested review from yann-lty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2020.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ChemicalXandco @natowi @fabiencastan @mike1158 @ToukL @servantftechnicolor @yann-lty @cvere