Add methods in ImageMatching and features in StructureFromMotion and FeatureMatching #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoleplomb
force-pushed
the
dev/imageMatchingMethods
branch
from
6cf3d23
to
c1cedd5
Compare
| @@ -70,6 +79,15 @@ class ImageMatching(desc.CommandLineNode): | |||
| uid=[0], | |||
| advanced=True, | |||
| ), | |||
| desc.IntParam( | |||
| name='nbNeighbors', | |||
| label='Nb Neighbors', | |||
There was a problem hiding this comment.
label='Sequential: Nb Neighbors',
| @@ -70,6 +79,15 @@ class ImageMatching(desc.CommandLineNode): | |||
| uid=[0], | |||
There was a problem hiding this comment.
label='VocTree: Nb Matches'
And same for all the other params
| @@ -54,7 +54,7 @@ class ImageMatching(desc.CommandLineNode): | |||
| ), | |||
| desc.IntParam( | |||
| name='minNbImages', | |||
| label='Minimal Number of Images', | |||
There was a problem hiding this comment.
Tree, Weights, Max Descriptors are also VocTree specific.
theoleplomb
force-pushed
the
dev/imageMatchingMethods
branch
from
02daf0b
to
4afa3c5
Compare
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
nbNeighborparam in ImageMatching for Sequential method.Add
minNumberOfMatchesparam in StructureFromMotion andfilterTrackForksoptionAdd
knownPosesGeometricErrorMaxparam andmatchFromKnownCameraPosesoptionFeatures list
[X] new Sequential method
[X] new Frustum method
[X] minNumberOfMatches
[X] knownPosesGeometricErrorMax
alicevision/AliceVision#730