From b6770498143f2bfffe801431383fa0ff8cbd55ec Mon Sep 17 00:00:00 2001 From: Jackson Tian Date: Thu, 28 Sep 2023 14:30:16 +0800 Subject: [PATCH] test: change REGION_ID to variable --- .github/workflows/go.yml | 2 +- sdk/auth/credentials/providers/instance_metadata_test.go | 2 +- sdk/auth/signers/signer_ecs_ram_role_test.go | 2 +- sdk/auth/signers/signer_ram_role_arn_test.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 224433911..3655b853b 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -28,7 +28,7 @@ jobs: env: ACCESS_KEY_ID: ${{ secrets.ACCESS_KEY_ID }} ACCESS_KEY_SECRET: ${{ secrets.ACCESS_KEY_SECRET }} - REGION_ID: ${{ secrets.REGION_ID }} + REGION_ID: ${{ vars.REGION_ID }} USER_ID: ${{ secrets.USER_ID }} PUBLIC_KEY_ID: ${{ secrets.PUBLIC_KEY_ID }} RSA_FILE_AES_KEY: ${{ secrets.RSA_FILE_AES_KEY }} diff --git a/sdk/auth/credentials/providers/instance_metadata_test.go b/sdk/auth/credentials/providers/instance_metadata_test.go index 372852ca5..4a76bd789 100644 --- a/sdk/auth/credentials/providers/instance_metadata_test.go +++ b/sdk/auth/credentials/providers/instance_metadata_test.go @@ -66,7 +66,7 @@ func TestInstanceMetadataProvider_Retrieve_Fail1(t *testing.T) { _, err := NewInstanceMetadataProvider().Retrieve() assert.NotNil(t, err) - assert.True(t, strings.Contains(err.Error(), "dial tcp: lookup invalid-domain-xxx:")) + assert.True(t, strings.Contains(err.Error(), "dial tcp: lookup invalid-domain-xxx")) } func TestInstanceMetadataProvider_Retrieve_Fail2(t *testing.T) { diff --git a/sdk/auth/signers/signer_ecs_ram_role_test.go b/sdk/auth/signers/signer_ecs_ram_role_test.go index 9ef09f99e..fc309198f 100644 --- a/sdk/auth/signers/signer_ecs_ram_role_test.go +++ b/sdk/auth/signers/signer_ecs_ram_role_test.go @@ -41,7 +41,7 @@ func Test_EcsRamRoleSigner_GetAccessKeyId(t *testing.T) { }() accessKeyId, err := s.GetAccessKeyId() - assert.True(t, strings.Contains(err.Error(), "dial tcp: lookup invalid-domain-xxx:")) + assert.True(t, strings.Contains(err.Error(), "dial tcp: lookup invalid-domain-xxx")) assert.Equal(t, "", accessKeyId) } diff --git a/sdk/auth/signers/signer_ram_role_arn_test.go b/sdk/auth/signers/signer_ram_role_arn_test.go index 1456c00da..41ab43e97 100644 --- a/sdk/auth/signers/signer_ram_role_arn_test.go +++ b/sdk/auth/signers/signer_ram_role_arn_test.go @@ -33,7 +33,7 @@ func Test_NewRamRoleArnSigner(t *testing.T) { assert.Equal(t, 3600, signer.credentialExpiration) c = credentials.NewRamRoleArnCredential("accessKeyId", "accessKeySecret", "roleArn", "", 100) - signer, err = NewRamRoleArnSigner(c, nil) + _, err = NewRamRoleArnSigner(c, nil) assert.NotNil(t, err) assert.Equal(t, "[SDK.InvalidParam] Assume Role session duration should be in the range of 15min - 1Hr", err.Error()) }