Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gitmoji option to commitConventions #205

Merged
merged 2 commits into from
Sep 4, 2019
Merged

feat: Add gitmoji option to commitConventions #205

merged 2 commits into from
Sep 4, 2019

Conversation

SnO2WMaN
Copy link
Contributor

@SnO2WMaN SnO2WMaN commented Sep 1, 2019

What:

Why:

#202

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for contributing!
Could you also update https://github.com/all-contributors/all-contributors/blob/master/docs/cli/configuration.md?

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for contributing!

Make sure all tests pass.

Also, could you also update https://github.com/all-contributors/all-contributors/blob/master/docs/cli/configuration.md?

@SnO2WMaN
Copy link
Contributor Author

SnO2WMaN commented Sep 4, 2019

Test is OK by #204. Thanks @simon300000 .

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Berkmann18 Berkmann18 merged commit 06bbb6e into all-contributors:master Sep 4, 2019
@Berkmann18
Copy link
Member

@all-contributors Please add @SnO2WMaN for code.

@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @SnO2WMaN! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SnO2WMaN SnO2WMaN deleted the feature/add-gitmoji-to-commitconvention branch September 4, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants