From 97878f496f10eb09327fe999484acf537c324196 Mon Sep 17 00:00:00 2001 From: Fabrizio <7031675+dexpota@users.noreply.github.com> Date: Sat, 19 Oct 2019 00:59:50 +0200 Subject: [PATCH] fix: add contributions (#211) * Fix issue #209 * Fix validation issue * Add myself to contributors list --- .all-contributorsrc | 10 ++++++++++ README.md | 32 ++++++++++++++++++++++---------- src/cli.js | 2 +- 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 11bd26c5..0d4101aa 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -352,6 +352,16 @@ "contributions": [ "code" ] + }, + { + "login": "dexpota", + "name": "Fabrizio", + "avatar_url": "https://avatars1.githubusercontent.com/u/7031675?v=4", + "profile": "https://www.destro.me", + "contributions": [ + "bug", + "code" + ] } ] } diff --git a/README.md b/README.md index 2d5e821a..e6210cfa 100644 --- a/README.md +++ b/README.md @@ -1,18 +1,19 @@ -- [ - all-contributors-cli - ](#all-contributors-cli) +- [ all-contributors-cli ](#all-contributors-cli) - [The problem](#the-problem) - [This solution](#this-solution) - [Using the all-contributors-cli](#using-the-all-contributors-cli) - - [Contributors](#contributors) + - [Contributors ✨](#contributors-) - [LICENSE](#license) -> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot) for automating the maintenance of your contributors table ✨
Say goodbye to command line tool dependencies and hello to the [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot) +> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot) +> for automating the maintenance of your contributors table ✨
Say goodbye +> to command line tool dependencies and hello to the +> [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot)

all-contributors-cli @@ -46,13 +47,14 @@ [![Code Coverage](https://img.shields.io/codecov/c/github/all-contributors/all-contributors-cli.svg)](https://codecov.io/github/all-contributors/all-contributors-cli) [![Version](https://img.shields.io/npm/v/all-contributors-cli.svg)](https://www.npmjs.com/package/all-contributors-cli) [![Downloads](https://img.shields.io/npm/dm/all-contributors-cli.svg)](http://www.npmtrends.com/all-contributors-cli) -[![All Contributors](https://img.shields.io/badge/all_contributors-34-orange.svg?style=flat-square)](#contributors-) +[![All Contributors](https://img.shields.io/badge/all_contributors-37-orange.svg?style=flat-square)](#contributors-) [![Star on Github](https://img.shields.io/github/stars/all-contributors/all-contributors-cli.svg?style=social)](https://github.com/all-contributors/all-contributors-cli/stargazers) ## The problem -You want to implement the [All Contributors](https://github.com/all-contributors/all-contributors) spec, but don't -want to maintain the table by hand +You want to implement the +[All Contributors](https://github.com/all-contributors/all-contributors) spec, +but don't want to maintain the table by hand ## This solution @@ -62,7 +64,10 @@ specification for your GitHub or GitLab repository. ## Using the all-contributors-cli -If you're looking to use the cli, head over to [the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview). The all-contributors website contains all the information required to install, configure and use the all-contributors-cli. +If you're looking to use the cli, head over to +[the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview). +The all-contributors website contains all the information required to install, +configure and use the all-contributors-cli. ## Contributors ✨ @@ -70,7 +75,8 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)): - + + @@ -120,8 +126,14 @@ Thanks goes to these wonderful people + + +
Jeroen Engels
Jeroen Engels
💻 📖 ⚠️		simon3000
simon3000
⚠️		 SnO₂WMaN
SnO₂WMaN
💻
Fabrizio
Fabrizio
🐛 💻
+ + + This project follows the diff --git a/src/cli.js b/src/cli.js index 57ea787d..e3d728c1 100755 --- a/src/cli.js +++ b/src/cli.js @@ -72,7 +72,7 @@ function startGeneration(argv) { } function addContribution(argv) { - const username = String(argv._[1]) + const username = argv._[1] === undefined ? undefined : String(argv._[1]) const contributions = argv._[2] // Add or update contributor in the config file return updateContributors(argv, username, contributions).then(data => {