diff --git a/.all-contributorsrc b/.all-contributorsrc index 3f9975d8..d285a80e 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -21,7 +21,8 @@ "avatar_url": "https://avatars.githubusercontent.com/u/1500684?v=3", "profile": "http://kentcdodds.com/", "contributions": [ - "doc" + "doc", + "code" ] }, { @@ -41,6 +42,16 @@ "contributions": [ "code" ] + }, + { + "login": "itaisteinherz", + "name": "Itai Steinherz", + "avatar_url": "https://avatars.githubusercontent.com/u/22768990?v=3", + "profile": "https://github.com/itaisteinherz", + "contributions": [ + "doc", + "code" + ] } ] } diff --git a/README.md b/README.md index fbee5edf..d6a550d3 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # all-contributors-cli -[![version](https://img.shields.io/npm/v/all-contributors-cli.svg)](http://npm.im/all-contributors-cli)[![All Contributors](https://img.shields.io/badge/all_contributors-4-orange.svg?style=flat-square)](#contributors) +[![version](https://img.shields.io/npm/v/all-contributors-cli.svg)](http://npm.im/all-contributors-cli)[![All Contributors](https://img.shields.io/badge/all_contributors-5-orange.svg?style=flat-square)](#contributors) This is a tool to help automate adding contributor acknowledgements according to the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. @@ -56,18 +56,22 @@ Where `username` is the user's GitHub username, and `contribution` is a `,`-sepa - code: πŸ’» - plugin: πŸ”Œ - tool: πŸ”§ + - infra: πŸš‡ - doc: πŸ“– - - question: ❓ + - translate: 🌍 + - question: πŸ’¬ - test: ⚠️ - bug: πŸ› - example: πŸ’‘ - blog: πŸ“ - tutorial: βœ… - - translate: 🌍 - video: πŸ“Ή - talk: πŸ“’ - design: 🎨 - review: πŸ‘€ + - financial: πŸ’΅ + - fundingFinding: πŸ” + - eventOrganizing: πŸ“‹ ## Configuration @@ -88,8 +92,8 @@ These are the keys you can specify: Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)): -| [
Jeroen Engels](https://github.com/jfmengels)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [
Kent C. Dodds](http://kentcdodds.com/)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [
JoΓ£o GuimarΓ£es](https://github.com/jccguimaraes)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [
Ben Briggs](http://beneb.info)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | -| :---: | :---: | :---: | :---: | +| [
Jeroen Engels](https://github.com/jfmengels)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [
Kent C. Dodds](http://kentcdodds.com/)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) [πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [
JoΓ£o GuimarΓ£es](https://github.com/jccguimaraes)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [
Ben Briggs](http://beneb.info)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | [
Itai Steinherz](https://github.com/itaisteinherz)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=itaisteinherz) [πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=itaisteinherz) | +| :---: | :---: | :---: | :---: | :---: | This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. diff --git a/lib/generate/format-contribution-type.test.js b/lib/generate/format-contribution-type.test.js index 43413eb6..a0ce89b0 100644 --- a/lib/generate/format-contribution-type.test.js +++ b/lib/generate/format-contribution-type.test.js @@ -16,7 +16,7 @@ test('should return corresponding symbol', t => { const {options} = fixtures(); t.is(formatContributionType(options, contributor, 'tool'), 'πŸ”§'); - t.is(formatContributionType(options, contributor, 'question'), 'πŸ’'); + t.is(formatContributionType(options, contributor, 'question'), 'πŸ’¬'); }); test('should return link to commits', t => { diff --git a/lib/generate/format-contributor.test.js b/lib/generate/format-contributor.test.js index 7c10785a..fa6cae01 100644 --- a/lib/generate/format-contributor.test.js +++ b/lib/generate/format-contributor.test.js @@ -25,7 +25,7 @@ test('should format contributor with complex contribution types', t => { const contributor = contributors.kentcdodds; const {options} = fixtures(); - const expected = '[
Kent C. Dodds](http://kentcdodds.com)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) πŸ‘€ πŸ’'; + const expected = '[
Kent C. Dodds](http://kentcdodds.com)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) πŸ‘€ πŸ’¬'; t.is(formatContributor(options, contributor), expected); }); diff --git a/lib/util/contribution-types.js b/lib/util/contribution-types.js index 815d83ae..1868b370 100644 --- a/lib/util/contribution-types.js +++ b/lib/util/contribution-types.js @@ -42,7 +42,7 @@ var defaultTypes = { description: 'Plugin/utility libraries' }, question: { - symbol: 'πŸ’', + symbol: 'πŸ’¬', description: 'Answering Questions' }, review: { @@ -73,6 +73,18 @@ var defaultTypes = { video: { symbol: 'πŸ“Ή', description: 'Videos' + }, + financial: { + symbol: 'πŸ’΅', + description: 'Financial' + }, + fundingFinding: { + symbol: 'πŸ”', + description: 'Funding Finding' + }, + eventOrganizing: { + symbol: 'πŸ“‹', + description: 'Event Organizing' } };