Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Length penalty for nn.beam_search.BeamSearch #5113

Closed
nicola-decao opened this issue Apr 12, 2021 · 1 comment · Fixed by #5208
Closed

Length penalty for nn.beam_search.BeamSearch #5113

nicola-decao opened this issue Apr 12, 2021 · 1 comment · Fixed by #5208

Comments

@nicola-decao
Copy link
Contributor

I see that in nn.beam_search.BeamSearch there is no way to specify the length penalty. How is implemented now? Is it using length penalty or not?

I imagine that the desiderata should be to use a simple penalty but I cannot understand from the code if that is the case.

@epwalsh
Copy link
Member

epwalsh commented Apr 13, 2021

There is not a length penalty at the moment, but this option would be a welcome addition to the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants