Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

cached_path should handle "gs://" (Google Cloud Storage) URLs just like it does for "s3://" or "hf://" #5150

Closed
epwalsh opened this issue Apr 23, 2021 · 4 comments · Fixed by #5173
Labels
Contributions welcome Feature request Good First Issue A great place to start for first time contributors
Milestone

Comments

@epwalsh
Copy link
Member

epwalsh commented Apr 23, 2021

We could utilize https://github.com/googleapis/python-storage to make this robust.

@epwalsh epwalsh added this to the 2.6 milestone Apr 23, 2021
@epwalsh epwalsh added Contributions welcome Good First Issue A great place to start for first time contributors labels Apr 23, 2021
@jmelot
Copy link
Contributor

jmelot commented Apr 26, 2021

Newbie here, but this looks pretty straightforward - I'd like to implement this! Could take a look this week.

@epwalsh
Copy link
Member Author

epwalsh commented Apr 26, 2021

That would be great @jmelot!

@AbhijayJ
Copy link

AbhijayJ commented May 2, 2021

Hey I would like to help in this if it hasn't been resolved yet

@jmelot
Copy link
Contributor

jmelot commented May 2, 2021

Hey @AbhijayJ, I actually have some time blocked out to try and finish up on this this afternoon, but if I run out of time and need to hand it off I'll let you know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributions welcome Feature request Good First Issue A great place to start for first time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants