Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using more robust method for detecting updates to input fields in Dragon #1028

Closed
NickColley opened this issue Oct 11, 2018 · 2 comments

Comments

@NickColley
Copy link
Contributor

In the character count component we repond to user input and update the message below the textarea indicating how many words or characters they have left.

In Dragon updating the textarea we found did not trigger the usual events since Dragon edits the value of the field directly, so we currently are doing a polling loop checking for changes in the value feed.

This matches the approach in the accessible autocomplete, but there has been a suggestion for another approach which looks less hacky.

alphagov/accessible-autocomplete#164 (comment)

Only downside I can see is that it wont support IE8, which we would need to determine if that's an issue given that most users will be using Internet Explorer 11 with Dragon

See the original discussion here: https://github.com/alphagov/govuk-frontend/pull/959/files#r211678196

@NickColley
Copy link
Contributor Author

I've done a bigger investigation here: #1530 (comment)

@NickColley
Copy link
Contributor Author

Given my investigation I don't think there is a way to improve this while keeping IE8+ support, I'll close this for now but it can be reviewed for example if we adopt custom elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants