Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why role="group" is applied automatically and consider removing #1483

Closed
EddieCurtis opened this issue Jul 8, 2019 · 2 comments

Comments

@EddieCurtis
Copy link

I have noticed the following error in our accessibility testing:

The “group” role is unnecessary for element “details”.

The attribute is added automatically by the file govuk-frontend-2.13.0.min.js (or relevant version number) in the dist directory of this project.

In my example the attribute is added to a <details> tag which changes from:
<details class="govuk-details govuk-!-margin-top-1">
to:
<details class="govuk-details govuk-!-margin-top-1" role="group">

I cannot work around this by adding role="none" to the source code as it still gets overwritten with role="group".

Please can we investigate why this attribute is being set, and consider removal to remove this error from our testing? This is very low priority for my team as we can ignore individual errors from the test results, but it might be a nice thing to investigate to see if we can improve.

@NickColley NickColley added the awaiting triage Needs triaging by team label Jul 8, 2019
@36degrees 36degrees added Effort: days and removed awaiting triage Needs triaging by team labels Jul 10, 2019
@36degrees
Copy link
Contributor

@NickColley was this addressed by #1523? Can this now be closed, as we're now only applying the role when we're polyfilling?

@NickColley
Copy link
Contributor

Yeah we can close this now, thanks for raising Eddie :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants