Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather performance stats with rollup-plugin-visualiser #3188

Closed
7 tasks
Tracked by #3279
domoscargin opened this issue Jan 19, 2023 · 1 comment
Closed
7 tasks
Tracked by #3279

Gather performance stats with rollup-plugin-visualiser #3188

domoscargin opened this issue Jan 19, 2023 · 1 comment

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jan 19, 2023

What

Use rollup-plugin-visualiser to gather stats on code performance.

This will build off work done in:

We want to initially just get rollup-plugin-visualiser working with our code and outputting info from our build. This will likely require creating a standalone stats-gathering rollup build, since the plugin requires rollup 3, and we're pinned to 0.59.4 for IE8 compatibility.

Why

As we're making changes to the way our JavaScript works, and other architectural changes, we'd like to keep track of how our changes impact the files we distribute.

Who needs to work on this

Developer

Who needs to review this

Developer

Done when

  • We can output stats and visual data from rollup-plugin-visualiser: [SPIKE] Collecting performance information #3239
  • We've decided which files and modules we want to track
  • Made issues for next steps:
    • Compare diff between pull requests and base branches
    • Github action to comment on PRs with these stats
    • Set up a way to store the data gathered to use for analysing trends
    • Decide what "good" looks like (after monitoring stats for a while)
@domoscargin
Copy link
Contributor Author

Closing in favour of #3279

@domoscargin domoscargin moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants