Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather built files sizes and display them in review app #3280

Closed
5 tasks
Tracked by #3279 ...
romaricpascal opened this issue Feb 13, 2023 · 0 comments · Fixed by #3681
Closed
5 tasks
Tracked by #3279 ...

Gather built files sizes and display them in review app #3280

romaricpascal opened this issue Feb 13, 2023 · 0 comments · Fixed by #3681

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Feb 13, 2023

Part of #3279

What

Collect the size of the files built in dist as well as package/govuk,
and display them in the review app 1.

Ideally this would work as a two step thing so the sizes may be displayed in other ways (like a comment on a PR) or stored somewhere more permanent.

If quick enough to add, it could be neat to also collect Gzip and Brotli size (the gzip-size and brotli-size packages may be helpful there).

Why

This is one of the steps towards keeping an eye on the size of the files we generate. It'll let us check if our changes introduce an unexpected variation of size in the built files.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Collect size of files built in dist and package/govuk into JSON
  • Render collected sizes on a page in the review app2
  • Either:
    • Collect Gzip and Brotli sizes
    • or
    • Create an issue for future collection of Gzip and Brotli sizes

Footnotes

  1. For humanizing the file sizes, the filesize package may come handy.

  2. This will/may call for building dist and package on heroku, which we might be able to speed up by running in parallel, using something like npm-run-all.

@romaricpascal romaricpascal added the awaiting triage Needs triaging by team label Feb 13, 2023
@kellylee-gds kellylee-gds removed the awaiting triage Needs triaging by team label Feb 14, 2023
@stevenjmesser stevenjmesser moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Mar 7, 2023
@colinrotherham colinrotherham self-assigned this Apr 4, 2023
@colinrotherham colinrotherham moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Apr 4, 2023
@colinrotherham colinrotherham linked a pull request May 25, 2023 that will close this issue
@colinrotherham colinrotherham moved this from In progress 📝 to Done 🏁 in GOV.UK Design System cycle board Jun 2, 2023
@colinrotherham colinrotherham removed their assignment Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants