-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display file sizes and module breakdown on pull requests #3282
Labels
Comments
3 tasks
stevenjmesser
moved this from Backlog 🗄
to Sprint Backlog 🏃🏼♀️
in GOV.UK Design System cycle board
Mar 7, 2023
5 tasks
domoscargin
moved this from Sprint Backlog 🏃🏼♀️
to In progress 📝
in GOV.UK Design System cycle board
Jun 21, 2023
domoscargin
moved this from In progress 📝
to Sprint Backlog 🏃🏼♀️
in GOV.UK Design System cycle board
Jun 26, 2023
domoscargin
moved this from Sprint Backlog 🏃🏼♀️
to In progress 📝
in GOV.UK Design System cycle board
Jul 13, 2023
domoscargin
moved this from In progress 📝
to Sprint Backlog 🏃🏼♀️
in GOV.UK Design System cycle board
Jul 26, 2023
Needn't block a pre-release, but we would like to do this before a full public release. |
domoscargin
moved this from Sprint Backlog 🏃🏼♀️
to In progress 📝
in GOV.UK Design System cycle board
Aug 1, 2023
domoscargin
moved this from In progress 📝
to Needs review 🔍
in GOV.UK Design System cycle board
Aug 3, 2023
domoscargin
moved this from Needs review 🔍
to Done 🏁
in GOV.UK Design System cycle board
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #3279
What
Add a comment on PR that summarises the statistics collected from the content of our package. This may include (to keep below the 65536 character limit of comments):
The comment should include the SHA of the commit the stats relate to, so we can check it is up to date with the tip of the PR branch. To cater for times where this may get out of sync, the workflow collecting the stats should be runnable manually.
If possible, the code for posting comments on the PR should be made generic so we can re-use it to add other comments on the PR (for example the diff of
dist
).1Why
Having these information accessible in the review app is handy, but hidden away. Commenting on the pull requests will give us more immediate access to the information.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
Footnotes
The approach could be the same as in the spike, but using a comment as marker to recognise the comment rather than actual content in the comment. ↩
Little note of caution around trying not to increase the build time on CI too much ↩
The text was updated successfully, but these errors were encountered: