Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors during Accordion initialisation if key HTML elements are missing #4126

Closed
1 task
Tracked by #3478
romaricpascal opened this issue Aug 24, 2023 · 2 comments · Fixed by #4266 or #4330
Closed
1 task
Tracked by #3478

Throw errors during Accordion initialisation if key HTML elements are missing #4126

romaricpascal opened this issue Aug 24, 2023 · 2 comments · Fixed by #4266 or #4330
Assignees
@domoscargin
Labels
accordion javascript
Milestone
v5.0

Comments

@romaricpascal
Copy link
Member

What

Update our JavaScript components requiring specific HTML elements to be present so they throw a MissingElementError (extending GOVUKFrontendError) rather than silently fail:

  • The sections of the accordion
  • Header in the section
  • <span> header
  • Heading
  • Toggle icon or text

Why

This is part of our work to have our components throw rather than silently return during initialisation.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Component has been updated to throw errors
@romaricpascal romaricpascal added awaiting triage Needs triaging by team javascript accordion and removed awaiting triage Needs triaging by team labels Aug 24, 2023
@romaricpascal romaricpascal added this to the v5.0 milestone Aug 24, 2023
This was referenced Aug 24, 2023
Closed
Closed
@domoscargin domoscargin moved this from Backlog 🗄 to Blocked ⛔ in GOV.UK Design System cycle board Aug 24, 2023
@domoscargin domoscargin moved this from Blocked ⛔ to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Sep 7, 2023
@romaricpascal
Copy link
Member Author

A little heads up on the wording, where we've tried to align the messages of the tests for the errors to throws when ... is missing [ + optional extra context]

@domoscargin domoscargin self-assigned this Sep 26, 2023
@domoscargin domoscargin moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Sep 26, 2023
@domoscargin domoscargin mentioned this issue Sep 27, 2023
Merged
@romaricpascal romaricpascal moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Oct 3, 2023
@domoscargin domoscargin moved this from Needs review 🔍 to Blocked ⛔ in GOV.UK Design System cycle board Oct 16, 2023
@domoscargin
Copy link
Contributor

Moving this to blocked while we work on #4299, to minimise conflicts.

@romaricpascal romaricpascal moved this from Blocked ⛔ to Needs review 🔍 in GOV.UK Design System cycle board Oct 23, 2023
@colinrotherham colinrotherham linked a pull request Oct 23, 2023 that will close this issue
Support beforeInitialisation() options, multiple modules #4330
Merged
@domoscargin domoscargin moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Oct 23, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoscargin domoscargin

Labels
accordion javascript
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
2 participants
@romaricpascal @domoscargin